Add optional parameters to PNConfiguration.__init__ #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional parameters to PNConfiguration.__init__ allowing developers to set subscriber_key, publish_key, and uuid during initialization.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
parfeon
reviewed
Jan 26, 2026
| def __init__(self): | ||
| def __init__(self, | ||
| subscribe_key: Optional[str] = None, | ||
| publish_key: Optional[str] = None, |
Contributor
There was a problem hiding this comment.
@jguz-pubnub shouldn't only publish_key be optional? All non-publish endpoints require subscribe_key and we also made uuid required as well (we need to start migration to the userId).
Contributor
There was a problem hiding this comment.
It won't be backward compatible. So maybe for now we can have it, but should plan some migration and notification about deprecation.
parfeon
approved these changes
Jan 26, 2026
Contributor
parfeon
left a comment
parfeon
left a comment
There was a problem hiding this comment.
We maybe need to add a note that PNConfiguration constructor without parameters will be deprecated, but in general looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add optional parameters to PNConfiguration.init
Add optional parameters to PNConfiguration.init, allowing developers to set subscribe_key, publish_key, and uuid during initialization
Closes #227